Closed NoLdman closed 1 month ago
sake may wrongly exit early on its which check, since the current implementation does the following:
sake
which
command -v
This solution is problematic since the returned information string may include alias information (and more), which test -x can not interpret.
test -x
Additionally is the test -x check unnecessary since command -v already only returns executable command or fails if the command can not be found.
Therefore, I changed the source to just check for the exit status of command -v.
Run vendor/bin/sake dev/build on a POSIX compliant system, where which itself has been aliased.
vendor/bin/sake dev/build
Description
sake
may wrongly exit early on itswhich
check, since the current implementation does the following:command -v
information about thewhich
executableThis solution is problematic since the returned information string may include alias information (and more), which
test -x
can not interpret.Additionally is the
test -x
check unnecessary sincecommand -v
already only returns executable command or fails if the command can not be found.Therefore, I changed the source to just check for the exit status of
command -v
.Manual testing steps
Run
vendor/bin/sake dev/build
on a POSIX compliant system, wherewhich
itself has been aliased.Issues
Pull request checklist