Methods that matches this name were left public because there are currently being called directly
Notes
The 6.0.0 changelog has already been updated to broadly mention that extension hook implementations have been changed from public to protected, so no need to update changelog
Acceptance criteria
Go through the list of these of $doNotMakeHookProtected methods and where possible and appropriate, update code so they are not being called directly
If it's not sensible to stop calling the method directly, look for where the extend() call is and evaluate whether this should be
Changed to call the method directly
Removed
Updated so the method in the call to extend() is not the same name as the one being called directly
Change visibility on remaining extension hook methods that aren't called directly from public to protected
Follow up to this comment
There's a list of of
$doNotMakeHookProtectedin the extension-protector script created for this issueMethods that matches this name were left public because there are currently being called directly
Notes
Acceptance criteria
$doNotMakeHookProtectedmethods and where possible and appropriate, update code so they are not being called directlyextend()call is and evaluate whether this should beextend()is not the same name as the one being called directlypublictoprotected