silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 820 forks source link

Adjust pretty name of closures on PHP 8.4 #11264

Closed staabm closed 1 month ago

staabm commented 1 month ago

Description

related to https://github.com/php/php-src/pull/13550

see analog symfony change: https://github.com/symfony/symfony/pull/54614

Manual testing steps

Issues

Pull request checklist

GuySartorelli commented 1 month ago

Hi there, thank you for the contribution.

You've missed several important parts of the pull request description. Please fill out the template in full, including creating an issue to link to, explaining what this change actually does, and ticking the relevant check boxes.

You may find you need to adjust the pull request in order to check some boxes, for example your commit message doesn't match our guidelines.

staabm commented 1 month ago

hey.

I am not a silverstripe user and contributed this fix by scanning all over github for this particular problem. I don't know how to reproduce the issue at hand and I am not willing to invest more time into it.

I am ok with closing the PR in case you are not interessted in the fix.

thank you

GuySartorelli commented 1 month ago

Thanks for letting us know. In this case I'll close the PR, as it's not clear what benefit it would provide, if any.