Closed staabm closed 1 month ago
Hi there, thank you for the contribution.
You've missed several important parts of the pull request description. Please fill out the template in full, including creating an issue to link to, explaining what this change actually does, and ticking the relevant check boxes.
You may find you need to adjust the pull request in order to check some boxes, for example your commit message doesn't match our guidelines.
hey.
I am not a silverstripe user and contributed this fix by scanning all over github for this particular problem. I don't know how to reproduce the issue at hand and I am not willing to invest more time into it.
I am ok with closing the PR in case you are not interessted in the fix.
thank you
Thanks for letting us know. In this case I'll close the PR, as it's not clear what benefit it would provide, if any.
Description
related to https://github.com/php/php-src/pull/13550
see analog symfony change: https://github.com/symfony/symfony/pull/54614
Manual testing steps
Issues
Pull request checklist