search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 820 forks source link

FIX Respect explicit casting before casting arrays #11271

Closed GuySartorelli closed 2 weeks ago

GuySartorelli commented 2 weeks ago

Fixes https://github.com/symbiote/silverstripe-multivaluefield/actions/runs/9358332818/job/25759951695

1) Symbiote\MultiValueField\Tests\MultiValueFieldTest::testUpdate BadMethodCallException: Object->__call(): the method 'getValues' does not exist on 'SilverStripe\ORM\ArrayList'

This was caused by https://github.com/silverstripe/silverstripe-framework/pull/11244 which didn't respect explicit pre-defined casting before casting arrays.

Needs https://github.com/silverstripe/silverstripe-cms/pull/2960 for CI to be happy.

Issue