silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 820 forks source link

FIX remove write from SearchableDropdownTrait #11287

Closed johannesx75 closed 3 days ago

johannesx75 commented 1 week ago

Description

SearchableDropdownTrait was calling write() on the underling DataObject.

Manual testing steps

  1. Create Model with multiple has_one relations
  2. Save DataObject in ModelAdmin

Issues

Pull request checklist

I don't have a full understanding on how and where SearchableDropdownTrait and the SearchableDropdown are used. So I'm not sure about test coverage for SearchableDropdownTrait.