Closed digitall-it closed 5 days ago
I suggest revisiting the script to ensure that the use of the new syntax "${@}"
instead of the old ${*}
does not introduce unintended side effects.
The ${@}
syntax, when quoted, ensures each argument is preserved in its entirety, which is crucial for handling paths or options that include spaces. It's important to verify that this change maintains the desired behavior throughout the script.
Description
Expected Behaviour:
vendor/bin/sake
should function correctly regardless of where the PHP binary is located, even if the path includes spaces.Observed Behaviour: If the path to the PHP interpreter contains spaces, the script fails with an error because the path isn’t wrapped in quotes, leading to incorrect parsing of the command.
This fix ensures that all paths in the
sake
script are properly quoted to handle spaces and other special characters that might appear in directory names.Manual Testing Steps
vendor/bin/sake build
to ensure it picks up the PHP binary and executes without errors.sake
is used to ensure no other side effects are introduced by this change.Issues
11289
Pull Request Checklist
Additional Notes
Please review the changes and provide feedback or merge if everything is in order.
Thank you!