silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
720 stars 820 forks source link

MNT Ignore narrow no-break space in regex in tests #11291

Closed GuySartorelli closed 2 days ago

GuySartorelli commented 4 days ago

I ran framework's unit tests locally with MariaDB 11.4, and got some failures. The failures were a result of having U+202F instead of a regular space in the result. The tests I've updated don't really care what kind of space is used, so replacing the space with \h and allowing unicode matches resolves these problems.

Didn't see any repeats of this problem, so fingers crossed we don't see that in CI either once we make the change there.

Issue

GuySartorelli commented 2 days ago

I can't replicate this issue locally running 11.4 on a vanilla 5.2 install

Huh. Must be something weird with my setup then.