Rename Deprecation::withNoReplacement() - Githubissues

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

721 stars 821 forks source link

Rename Deprecation::withNoReplacement() #11382

Closed emteknetnz closed 2 months ago

emteknetnz commented 2 months ago

Deprecation::withNoReplacement() is a somewhat misnamed method in that while it's used for to wrap suppressing deprecation notices for classes/methods with no replacement, it's also used to suppress those notices when calling a deprecated method or creating a deprecated class.

This is somewhat confusing and it would be better if it was simply renamed

Acceptance criteria

[x] In CMS 5, rename the method to something like Deprecation::withSilentNotice()
[x] Rename all existing calls to withNoReplacement() to the new method
[x] Keep the old method and call the new method i.e. the old method name still works as an alias
[x] Update references to withNoReplacement() in docs

PRs

emteknetnz commented 2 months ago

@GuySartorelli Note that the fluent PR was merged with withSuppressedWarning which I've asked to be changed to withSuppressedNotice, so will need a new PR to fix that