search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

Check README attributions #11415

Open madmatt opened 1 day ago

madmatt commented 1 day ago

Module version(s) affected

4.x, 5.x, 6.x

Description

The README has an Attributions section in it, which hasn't been updated for quite some time. Either we should remove this, or update it to reference what we actually use. I don't think we use the icon set anymore, perhaps since v2 days, though I could be wrong?

How to reproduce

Just view the README file 😉

Possible Solution

No response

Additional Context

Closest other issue is a comment from Dan on https://github.com/silverstripe/silverstripe-framework/pull/6756 back in 2017 but this was missed as the PR was already merged and closed.

Validations

GuySartorelli commented 20 hours ago

Just view the README file

But I don't know which icons it's referring to. :p

madmatt commented 19 hours ago

I mean it links here - not sure we've used any of these icons in the past decade? :p https://p.yusukekamiyamane.com/

GuySartorelli commented 18 hours ago

Looks like blue-folder-horizontal in silverstripe/cms (yes I know, that's not this repo) is used from that website.

I'm not sure where the images in silverstripe/admin (again not this repo) came from, but some of them share a similar style to that website so may have originated from there. Many of them are bundled in spritesheets so I can't search for them by name like I could the folder.

So - yes, probably remove from this repo's readme, but looks like we need to add it to at least the cms readme and maybe the admin readme.

madmatt commented 18 hours ago

Huh - okay well if it's still relevant then we should keep it. I can't say I've seen any of those icons in a long time heh. The curse of long-term support strikes again ;)