silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

[2012-09-18] Publish button Disappears unexpectedly #1594

Closed silverstripe-issues closed 11 years ago

silverstripe-issues commented 11 years ago

created by: @vanlawrence (clawrence) created at: 2012-09-18 original ticket: http://open.silverstripe.org/ticket/7876


After changing page type to redirector or virtual page, saving draft the "publish" button disappears.

Changing pagetype doesn't give any indication you need to update the link to redirector/virtual page before you can publish.

TASK: Provide the user with instructions/ feedback indicating requirements for this action (perhaps a generic message at the top of the page).

silverstripe-issues commented 11 years ago

comment by: @jbridson (jbridson) created at: 2012-09-21


One solution I can think of would be to move or duplicate the link (to redirector/virtual page) dropdown to appear below the pagetype dropdown. This would give the user a call to action and would clarify the next step in the process.

I did notice that this behaviour only occurs on the first time you change a page to the redirector/virtual pagetypes. If you change the pagetype to another pagetype and then back to a redirector/virtual pagetype the link is already set so the save&publish button does not disappear.

silverstripe-issues commented 11 years ago

comment by: rmichell created at: 2012-11-30


silverstripe-issues commented 11 years ago

comment by: @kmayo-ss (kmayo) created at: 2012-12-03


VirtualPage->isPublishable is returning false which bubbles up to SiteTree->getCMSActions via VirtualPage->canPublish.

silverstripe-issues commented 11 years ago

comment by: @kmayo-ss (kmayo) created at: 2012-12-03


Created the following branch on Rebel Alliance which adds a pages dropdown to the settings tab for Virtual Pages, it also displays a warning

https://github.com/silverstripe-rebelalliance/silverstripe-cms/commit/764af1ef1689a58b12c13126df89140e1e9aae02

Will probably do a pull request tomorrow

silverstripe-issues commented 11 years ago

comment by: @kmayo-ss (kmayo) created at: 2012-12-05


Added a branch to rebel alliance sapphire as well to solve a change tracker issue

https://github.com/silverstripe-rebelalliance/sapphire/commits/7678

silverstripe-issues commented 11 years ago

comment by: @kmayo-ss (kmayo) created at: 2013-01-07


Created the following commit/branch and updated the discussion on Github

https://github.com/silverstripe-rebelalliance/silverstripe-cms/commit/a9d273f8120590d19426a5cf1437de3cd9271413

chillu commented 11 years ago

See https://github.com/silverstripe/silverstripe-cms/pull/683. @kmayo-ss @jbridson could you review please?