search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

[2013-03-08] Clearer errors on HTML5Lib parse fails (point to failing line) #1699

Closed silverstripe-issues closed 10 years ago

silverstripe-issues commented 11 years ago

created by: @chillu (ischommer) assigned to: hfried created at: 2013-03-08 original ticket: http://open.silverstripe.org/ticket/8306

Related to https://github.com/silverstripe/sapphire/commit/db56d17056b52c09fdf1e39641a268bcac3c9eac, see http://open.silverstripe.org/ticket/8305 for more details.

Any markup which the used (alpha) HTML5 lib considers invalid will throw a fatal error. And to add insult to injury, it doesn't even tell you what is actually wrong: http://monosnap.com/image/jJBq8dFNEzkgpyPCHvvHbLVJZ This has the potential to significantly impact developer workflow on petty issues like markup validness.

The lib itself says: "Warning: This is a pre-alpha release, and as such, certain parts of this code are not up-to-snuff (e.g. error reporting and performance)." - https://github.com/falexandrou/html5lib-php

We need error reporting which tells on you which part of the HTML it chokes. I don't even expect a clear explanation why it chokes, but having it throw a generic error on a HTML string potentially thousands of characters long is not acceptable.

silverstripe-issues commented 11 years ago

comment by: @chillu (ischommer) created at: 2013-03-08

I've attached the faulty content, rendering the "gridfield test" page from the frameworktest module in a standard install, so should be easy to reproduce. Its beside the point though what specifically is wrong in this template.

silverstripe-issues commented 11 years ago

comment by: @stojg (stojg) created at: 2013-03-19

[I deleted this bug report since it was a fault in my composer that made the beta version to stick to an older version]

silverstripe-issues commented 11 years ago

comment by: hfried created at: 2013-03-19

html5lib isn't in framework any more (as of https://github.com/silverstripe/sapphire/commit/53128c5d2ff44cdb958e69a2dd4a1ebb9355929a), but in it's own module instead (https://github.com/silverstripe/silverstripe-html5)

We would still ideally get that module to report issues better, but not urgent for 3.1 any more

simonwelsh commented 10 years ago

Not a framework issue. If this is still a problem, please report it to the linked module.