search

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

Tabs in admin/pages don't float inline #1778

Closed chillu closed 11 years ago

chillu commented 11 years ago

This is a pretty visible part of our UI, in a very common browser (latest Chrome). We should fix before 3.1 final: http://monosnap.com/image/GAOJwMOgdfd1o2ICCea3OckhY

hafriedlander commented 11 years ago

This was broken when I removed a hack that basically called jlayout.layout repeatedly as part of the side panel preview change. Not only was that fix pretty ugly, it also hammered resize performance, to the point that resizing the window (or animating the edit / preview split) was slow to the point of painfulness.

Note to whoever is tackling this: don't do that :). Make sure you understand how jlayout.layout propagates through it's children.

wilr commented 11 years ago

Is it still an issue? On latest chrome for me, 3.1 checkout seems to work fine...

ajshort commented 11 years ago

From what I remember this occurs pretty intermittently, but regularly enough to be an issue.

halkyon commented 11 years ago

Yup, this still occurs intermittently in 3.1.

wilr commented 11 years ago

Sweet, if anyone can provide instructions to trigger it on demand happy to look into it. Spent 10 minutes saving and editing pages and didn't stumble over it (latest chrome, latest checkout)

ARNHOE commented 11 years ago

I am not sure how to "trigger" it, but I usually get it after I have dev/build?flush=all and I open the admin area.

oddnoc commented 11 years ago

Not unexpectedly, this happens also in Safari.

willmorgan commented 11 years ago

I got it when I refreshed the CMS under "Pages", then went to "Settings" and then refreshed.

I opened Chrome's inspector, unchecked the float:none; setting on screen.css:408 (the div with role=tablist) and then it fixed itself.

But the weird thing is that when I rechecked it, the thing didn't break again.

tractorcow commented 11 years ago

Maybe it's something to do with the CMS content being cached. I've had this happen intermittently myself, but I thought it was just me!

tractorcow commented 11 years ago

Fixed with https://github.com/silverstripe/sapphire/pull/1863

halkyon commented 11 years ago

...still not fixed right? ;-)

tractorcow commented 11 years ago

Sorry, it's still unfixed.

wilr commented 11 years ago

Will close for the better fix for tabs breaking over multiple lines. Error only occurs in specific error states.

chillu commented 11 years ago

See https://github.com/silverstripe/silverstripe-framework/pull/2090

ARNHOE commented 11 years ago

The tabs no longer seem to be acting so weird. But I am getting the following now in Chrome 28 beta.

schermafbeelding 2013-06-16 om 16 58 18

And a simple refresh doesn't seem to fix this.

chillu commented 11 years ago

Doh sorry about that, fixed css regression in 04c337dc8242fc7da3009002bf4673a545109dda. Removed the inline-block styles, but didn't think they were meant to apply to child elements as well. Tested in Chrome and IE8. Works fine, apart from longer breadcrumbs not breaking into multiple lines in IE8, but tabs vs. breadcrumbs do cause newlines which is the main desired effect.