silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

Rename Sapphire classes to something else #2562

Closed stojg closed 11 years ago

stojg commented 11 years ago

This is a minor thing, but I was just creating a SapphireTest and it struck me that Sapphire doesn't make any sense to someone who picks up SilverStripe today.

These are the Filenames I could find that starts with Sapphire:

./dev/SapphireInfo.php ./dev/SapphireREPL.php ./dev/SapphireTest.php ./dev/SapphireTestReporter.php ./dev/SapphireTestSuite.php ./templates/SapphireInfo.ss ./thirdparty/tabstrip/images/sapphire.tabs.css

Renaming them to Framework* might not make any sense either?

chillu commented 11 years ago

Awww, you're neglecting our heritage!! :D Sam and me have made that conscious decision to keep those for the time being when I moved classes around in the wake of splitting of "framework". I'd suggest we leave this until the big namespace rewrite (tm)

stojg commented 11 years ago

I'm happy with that. All hail to the big Namespace rewrite!

sminnee commented 11 years ago

Agreed. As part of the namespace rewrite I'd like us to have some kind of class-renaming script that can traverse a codebase and replace once classname with another reasonably reliably. This would be helpful with that.

wilr commented 11 years ago

R.I.P Sapphire.