silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
722 stars 822 forks source link

GridField "print" feature is broken (at least in admin/reports) #5938

Closed chillu closed 7 years ago

chillu commented 8 years ago

Pull requests

Screenshot of button

image

HboyVinod commented 7 years ago

Seems to be working fine on Firefox 50.1.0 and Chromium 55.0.2883.87 (note using alpha3, but I will retest using dev-master) What do you mean by "broken"?

EtherealTallow commented 7 years ago

print I was able to replicate in this Chromium 55.0.2883.87 and Firefox 50.1.0 using dev-master. Pressing the print button seems to remove the toolbar containing the print option and the export to csv button (as seen above), where as before (alpha3) it would open a new tab with a printable version of the report, and open the print dialog. I will be working on fixing this problem this afternoon, so any help with why this might be happening would be appreciated.

HARVS1789UK commented 7 years ago

@EtherealTallow did you get anywhere with this yet?

I have not used this option before, so I am not sure what it is supposed to look like, but I was a bit surprised when I just got this:

screen shot 2017-02-16 at 09 56 43

Especially as the print/export toolbar disappears as well as you have stated.

I need to make use of the print function for a number of SS_Reports, so im hoping a fix is on the way from someone. Where have you gotten to so far, is there anything I may be able to help with?

EtherealTallow commented 7 years ago

I didn't manage to narrow down what was causing the problem, but I definitely haven't seen what happened in your above image. I suspect that the original problem is related to the JavaScript, which I struggle to comprehend at the best of times. Sorry I couldn't be much help.

chillu commented 7 years ago

Confirmed this is still the case with master

flamerohr commented 7 years ago

Caused by classes being shifted around and then broke even more with the module splitting... :(

Pull requests are up that will fix both issues

tractorcow commented 7 years ago

Fixed.