[FORMS] GroupedList fails with an ArrayList of plain PHP Objects

[wernerkrauss]

Fatal error: Call to undefined method MyPlainObject::hasMethod() in /vagrant/www/framework/model/GroupedList.php on line 21

https://github.com/silverstripe/silverstripe-framework/blob/3.5/model/GroupedList.php#L21

[robbieaverill]

method_exists($item, 'hasMethod')? 😄

[wernerkrauss]

@robbieaverill sure... but hasMethod() also checks methods on DataExtensions, so it's not just a replacement.

I wrote a local solution:

protected function getKeyOfItem($item, $index) {

    if (is_object($item)) {
        if (method_exists($item, 'hasMethod') && $item->hasMethod($index)) {
            return $item->$index();
        }

        //fallback for plain PHP objects
        if (method_exists($item, $index)) {
            return $item->$index();
        }

        return $item->$index;
    }

    return $item[$index];
}

If you think it's a good enhancement I can make a PR against 3.5

[sminnee]

Seems like a reasonable patch.

[dhensby]

@wernerkrauss did you ever submit the patch to 3.5?

[tractorcow]

@wernerkrauss It'd be better to group the condition if you can help it, rather than duplicate the action. Do you want to PR? :P