Closed chillu closed 7 years ago
Do we have to fix cookies (and everything else related to the controller stack) as part of this ticket? It feels like it's turning into a cascade of "fix everything annoying" ;-)
If I were to refactor cookie, I'd probably have a middleware that
However that's well beyond the scope of this card
I've had a discussion with @chillu and decided to update the scope of the request / response refactor.
https://gist.github.com/tractorcow/2bb76d12074b885b9b2923dafa07ae88
Cookies API remains unchanged, but we will move Session::inst() into $request->getSession().
Old ACs:
new
vs. dependency injection)Injector
and Config
in core classesConfig::nest()
global state)DataModel
method arguments)New ACs:
Nice +1 thanks @chillu
Just so that everyone here is clear, we are going to close and accept this RFC pretty early next week. Please get in your concerns early if you have anything you would like to add.
Hello, the discussion seems to have tailed off, and given our general agreement on approach we will close this discussion and move onto implementation.
todo : update A/C and task.
I've just updated the tasks for this story. Quite a lot of progress made so far!
I've added WIP branches to the initial story body.
New progress:
🎉🎉🎉
Acceptance Criteria
Excludes
Notes
$this->app->get('my-dependency')
)RFC Versions
Related
Tasks
WIP branches