Closed tractorcow closed 7 years ago
@flamerohr I'd like to discuss what the UI looks like with this one as I haven't supplied any design since a long time and it looks like the direction has changed a fair bit.
@clarkepaul sounds good, I had wanted to touch base about the design soon too :)
@flamerohr Just a note that I think find-as-you-type is out of scope here (not in ACs), because it's very likely too slow in the current implementation. Also, please doublecheck that you've implemented all of the ACs, the tasks don't reflect stuff like keyboard accessibility.
@clarkepaul Where do you see the "stats" counters being used? If they're counting recursively, they're going to be resource intensive to create. And I don't see the need for them, given we have a flattened search now.
@chillu sorry, I'm not sure what you're referring to with "find-as-you-type"? Yes, I'm checking keyboard accessibility and other ACs, I didn't believe they warranted a task though
@chillu they were already implemented in the POC so I did designs for them but since then @flamerohr and myself think it's mostly just clutter and isn't clear if its recursive results anyway, so we decided that it will be removed.
Acceptance Criteria
Tasks
tree
field API to account for search, and showing in a flat list.Design
https://projects.invisionapp.com/boards/D3X68PS46K28/
Nice-to-have (?)
Out of scope
Notes
Related
Pull requests