silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
721 stars 821 forks source link

Test failures affected by global state in CWP 2.0 #8105

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Context: CWP 2.0.0, SilverStripe 4.1.1, CWP starter theme, silverstripe/html5 module

Some test failures which are checking template markup content are failing:

Some of these are looking for CSS selectors that depend on either no theme at all or the simple theme installed. In the case of the former we should enforce disabling themes in the tests that don't expect one to override templates, and in the case of the latter we should remove this coupling (I suspect it's the former though).

Also some tests are probably affected by silverstripe/html5 being installed, since the expectations fail due to two HTML tags being on separate lines rather than one single line.

robbieaverill commented 6 years ago

Fixed with #8124