silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
722 stars 822 forks source link

GridField - no spacing below #9154

Open christopherdarling opened 5 years ago

christopherdarling commented 5 years ago

Affected Version

Running SilverStripe 4.4.1

Description

When creating a TextField underneath a GridField there is no space between, see below; Screenshot 2019-07-30 at 11 24 21

Edit: just to add - only an issue when there are no records and the pagination summary row isn't visible

Steps to Reproduce


    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->addFieldsToTab('Root.Main', [
                new TextField('FieldAbove'),
                new GridField(
                    'Sections',
                    'Sections',
                    $this->Sections(),
                    new GridFieldConfig_RelationEditor()
                ),
                new TextField('FieldBelow'),
            ]);
        });

        return parent::getCMSFields();
    }

PR

sabina-talipova commented 2 years ago

Probably, we could include this issue in more complex design epic in the future.