Inconsistency on the re-login dialog

silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS

https://www.silverstripe.org

BSD 3-Clause "New" or "Revised" License

721 stars 821 forks source link

Inconsistency on the re-login dialog #9388

Open maxime-rainville opened 4 years ago

maxime-rainville commented 4 years ago

Description

When your session expires in the CMS you will be prompted to log back in in a modal. This Modal displays an iFrame with a login screen.

The button styles for the modal don't match the admin ones.
There's a blank space with subtly different background colour below the iframe

Steps to Reproduce

Access the CMS
Using your browser's dev tool delete your session cookie.
Navigate to different page

maxime-rainville commented 4 years ago

@silverstripeux Don't know how much you care about this. I'm thinking, it could be worthwhile redoing this thing in react with form schemas instead of using an iframe.

clarkepaul commented 4 years ago

The visual layout of this is shocking. Form schemas should allow for more control and less fragile styles I hope :)

Cheddam commented 4 years ago

Guessing this just wasn't looked at during the migration to Bootstrap in CMS 4 😅

ScopeyNZ commented 4 years ago

I feel like that isn't how it looked about a year ago in the CMS.

maxime-rainville commented 4 years ago

It's not something we look at very often. Because it's an iframe, it's got a somewhat different context than the rest of the admin area, so global style changes could very well have unusual affect in here.

I'll add a test entry for it in our HipTest/CucumberStudio.

maxime-rainville commented 4 years ago

Just added an entry to Cucumber https://studio.cucumber.io/projects/103281/test-plan/folders/705103/scenarios/4186105

sachajudd commented 4 years ago

This is one of the only designs I can find for the timeout modal @clarkepaul Timeout design. Let me know if this is still the direction we are going for and I'll upload to DSM.