silverstripe / silverstripe-framework

Silverstripe Framework, the MVC framework that powers Silverstripe CMS
https://www.silverstripe.org
BSD 3-Clause "New" or "Revised" License
722 stars 821 forks source link

Review multi-module build schedules / config #9724

Open sminnee opened 3 years ago

sminnee commented 3 years ago

Silverstripe modules can impact each other, and the unreleased version of framework can potentially break modules. In addition to the commit-triggered builds, we need a regular cadence of scheduled builds.

The most efficient place to do this are multi-module builds. We have these on the following modules:

Initially I had reviewed recipe-core and recipe-cms and was going to suggest that we increase these to daily. I see that installer and kitchen-sink have daily builds where it matters so I'll pull back on that.

However, it is notably that only installer has behat builds being executed. According to @emteknetnz this has been difficult to remedy - we haven't been able to get behat running on the kitchen sink builds.

That said, behat on the kitchen sink build would be valuable if possible. If not, running scheduled behat builds on individual modules is an option, but will be more time consuming to maintain.

If we do figure out how to run behat builds on recipes, then I would probably recommend that we run behat & phpunit builds on core, cms, and kitchen sink, and drop the scheduled multi-module config from installer as it would be a duplicate.

In any case, it would be good to document this in the contributor docs.

brynwhyman commented 3 years ago

This is where the conversation got to on getting Behat tests running on kitchen-sink: https://github.com/silverstripe/cwp-recipe-kitchen-sink/issues/10