silverstripe / silverstripe-fulltextsearch

Adds external full text search engine support to Silverstripe
BSD 3-Clause "New" or "Revised" License
44 stars 83 forks source link

Pagination in search results broken #228

Closed sanderha closed 6 years ago

sanderha commented 6 years ago

I might be missing something, but it seems generated search results does not care about the "start" GET variable. Shouldnt this method SilverStripe\FullTextSearch\Solr\Forms\SearchForm::getResults() account for that? I fixed it in my own SearchForm class by adding this:

        $searchTerms = $request->requestVar('Search');
        $start = $request->requestVar('start');
        $query = SearchQuery::create()->addSearchTerm($searchTerms)->setStart($start);

Apologies if I missed something obvious

Using SS v4.1 and v3.3 of this module

robbieaverill commented 6 years ago

@sanderha would you like to make a pull request to fix this?

sanderha commented 6 years ago

229 There ya go

robbieaverill commented 6 years ago

Fixed in #229, thank you