NEW Ensure commits are visible to seachers (fixes #274)

silverstripe / silverstripe-fulltextsearch

Adds external full text search engine support to Silverstripe

BSD 3-Clause "New" or "Revised" License

44 stars 83 forks source link

NEW Ensure commits are visible to seachers (fixes #274) #278

Closed chillu closed 2 years ago

chillu commented 4 years ago

This is required in situations where autoCommit.openSearcher is set to "false", and you don't want to rely on core restarts to make committed index updates available to new searches. It's already configured like this in the Common Web Platform environments, so this change will mainly affect other environments (such as Silverstripe Platform). To opt out of this new behaviour, set up a custom solrconfig.xml.

More details in https://github.com/silverstripe/silverstripe-fulltextsearch/issues/274

chillu commented 4 years ago

Sorry for the whitespace changes, I blame PHPStorm ;) Still testing this out on SilverStripe Platform, haven't successfully indexed content through it.

Also note that I haven't changed this for Solr 3, because who the hell cares about that.

adrexia commented 3 years ago

Is there a reason this hasn't been merged yet?

michalkleiner commented 3 years ago

I think everyone was waiting for @chillu as he indicated in his last comment he still hadn't successfully indexed content through it, so I think everyone was looking at this as a draft PR.

Can you please confirm what's the status of this @chillu? Thanks!

emteknetnz commented 2 years ago

I've tested this on multiple platforms and things now work as expected

emteknetnz commented 2 years ago

I've released this as 3.11.0