silverstripe / silverstripe-fulltextsearch

Adds external full text search engine support to Silverstripe
BSD 3-Clause "New" or "Revised" License
44 stars 83 forks source link

DEP Move solr-php-client with PHP 8.1 compatbility to thirdparty folder #320

Closed emteknetnz closed 2 years ago

emteknetnz commented 2 years ago

Issue https://github.com/silverstripe/silverstripe-framework/issues/10250

I attempted to update this upstream but got no response. Looks abandoned. So just adding to thirdparty folder instead.

The COPYING.md file says it's ok to copy this, as long as copyright is retained

Includes a fix to add method attribute to Document::getIterator() for PHP 8.1 compatibility

dhensby commented 2 years ago

Potentially time to migrate to https://github.com/solariumphp/solarium ? I think I looked into this quite some time ago, not sure what happened to it, though.

emteknetnz commented 2 years ago

That seems like substantially more work. There was only a single line required to get this php 8.1 compatible (at least according to unit tests).

dhensby commented 2 years ago

Yeah, I think that moving to solarium should be a long-term project and not a way to solve php 8.1 compatibility. We should probably aim not to be reliant on libraries that are abandoned or haven't seen any effort in 6 years!

GuySartorelli commented 2 years ago

FYI

I was the primary author. This was created for a product which no longer exists, but was acquired by PTC. There is unlikely to be any changes here as I am no longer part of PTC. Anyone still using this probably forks to publish or vendor their own version. Sorry for your inconvenience.

emteknetnz commented 2 years ago

Thanks for forking the module @dhensby - we'll use that. I've created a follow up PR to fix a couple of things on the fork