A bunch of templates and logic to render that toolbar on silverstripe.org and save different versions of it to /assets/. This only runs on silverstripe.org.
A profile URL that is hosted on silverstripe.org and iframed into the other sites.
If my understanding is correct, my recommendation is that we roll the functionality of the 2nd and 3rd bullets into the ssorg project itself, as right now detailed of the website layout end up being scattered across these two modules, increasing complexity without value.
The "public API" that silverstripe.org would need to expose is:
ensure that the right assets URLs kept hosting the different navigations for each site.
ensure that toolbar/profile returns the content of the top-right (although to be honest this is only necessary inasmuch as toolbar content it provides continues to reference it)
This module would then be a lot simpler and limited in scope to the first bullet.
Keen to get @unclecheese, @robbieaverill's, and @lexakami's view on that.
If I understand the architecture of this module correctly, it's got two parts.
A small support class, https://github.com/silverstripe/silverstripe-globaltoolbar/blob/master/src/TemplateProvider.php, that fetches a rendered toolbar from silverstripe.org. This is used by all satellite sites, and possibly, by silverstripe.org itself.
A bunch of templates and logic to render that toolbar on silverstripe.org and save different versions of it to /assets/. This only runs on silverstripe.org.
A profile URL that is hosted on silverstripe.org and iframed into the other sites.
If my understanding is correct, my recommendation is that we roll the functionality of the 2nd and 3rd bullets into the ssorg project itself, as right now detailed of the website layout end up being scattered across these two modules, increasing complexity without value.
The "public API" that silverstripe.org would need to expose is:
This module would then be a lot simpler and limited in scope to the first bullet.
Keen to get @unclecheese, @robbieaverill's, and @lexakami's view on that.