search

silverstripe / silverstripe-graphql

Serves Silverstripe data as GraphQL representations
BSD 3-Clause "New" or "Revised" License
52 stars 61 forks source link

MNT Update expected data #533

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

Issue https://github.com/silverstripe/.github/issues/39

I'm not entirely sure why the actual output changed, though at the same time I don't think we need to spend time investigating it either

sabina-talipova commented 1 year ago

@emteknetnz, should we do these changes for 4.3 as well? Since initially this test case was implemented for CMS 4 and we still have this test as failed in CMS 4.

emteknetnz commented 1 year ago

@sabina-talipova It's not failing for 4.3? https://github.com/silverstripe/silverstripe-graphql/actions/workflows/ci.yml?query=branch%3A4.3

I'll close the linked issue, though you can point me to something that's failing I'm happy to reopen and update it for 4.3