silverstripe / silverstripe-graphql

Serves Silverstripe data as GraphQL representations
BSD 3-Clause "New" or "Revised" License
52 stars 61 forks source link

Revert "test(SortPlugin): add integration test for multi-sort" #550

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

This reverts commit 47811b88cd1ae7e39cf13ed698223f6a13b4d047.

For reasons that I do not understand, while graphql 4.3 is currently green, there are failures when running this in the context of silverstripe/installer and sink

Do not merge unless this is green - https://github.com/emteknetnz/silverstripe-installer/actions/runs/5959183341

1) SilverStripe\GraphQL\Tests\Schema\DataObject\InheritanceBuilderTest::testFillAncestryInjectorSubclass Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'SilverStripe\GraphQL\Tests\Fake\Inheritance\MySubclass' +'SilverStripe\GraphQL\Tests\Fake\Inheritance\MyOrig'

On my local the failure was 1) SilverStripe\GraphQL\Tests\Schema\IntegrationTest::testFilterAndSort Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'test2' +'test3'

emteknetnz commented 1 year ago

Incorrect