SS5 update and fix for issue #194

PixNyb commented 6 months ago

Description

This pr includes support for ss5 and fixes #194

[ ] The target branch is correct
- See picking the right version
[x] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[x] The commit messages follow our commit message guidelines
[ ] The PR follows our contribution guidelines
[x] Code changes follow our coding conventions
[x] This change is covered with tests (or tests aren't necessary for this change)
[x] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[ ] CI is green

GuySartorelli commented 6 months ago

The 4.x release line of this module already supports Silverstripe CMS 5.

Please remove all changes which are not related to the specific issue this PR aims to fix. Please also target this PR to the 4.0 branch.

GuySartorelli commented 5 months ago

@PixNyb Are you still interested in getting this merged in?

If so, please make the requested changes above. If not, I will close this PR.

GuySartorelli commented 3 months ago

@PixNyb looks like you made some new commits, but you haven't addressed anything I said in https://github.com/colymba/GridFieldBulkEditingTools/pull/274#issuecomment-2068206946

I am going to close this PR - feel free to open a new one with only the relevant commits, targetting the correct branch.