silverstripe / silverstripe-gridfield-bulk-editing-tools

Silverstripe CMS GridField components for bulk upload and bulk record edit, unlink & delete :package::boom:
BSD 3-Clause "New" or "Revised" License
88 stars 81 forks source link

Fix incorrect CMS layout widths when bulk editing #295

Closed kinglozzer closed 1 month ago

kinglozzer commented 4 months ago

Description

The edit form is missing the necessary CSS class to ensure its width is consistent with other CMS sections.

Before:

Screenshot 2024-07-08 at 11 33 50

After:

Screenshot 2024-07-08 at 11 33 57

Manual testing steps

Bulk edit something. My edit form includes an UploadField, not sure if that's relevant in triggering this, but it's definitely more noticeable at smaller screen sizes.

Issues

Pull request checklist

GuySartorelli commented 4 months ago

Thanks for raising this!

Since this is a commercially supported module, and commercial support for CMS 4 is now in "security patches only" phase, I can't merge this against the branch it's currently targetting without @colymba saying they're okay with a patch release for the CMS 4 compatible versions.

The alternative would be to retarget this PR to 4.0.

lekoala commented 1 month ago

the edit handler is really broken at the moment see https://github.com/colymba/GridFieldBulkEditingTools/pull/308

for the layout specifically, it also needs fill-height

would be great to have a working feature for the current silverstripe version :)

GuySartorelli commented 1 month ago

Closing in favour of https://github.com/colymba/GridFieldBulkEditingTools/pull/308