Closed mooror closed 2 months ago
There are a lot of commits on here that aren't related to your change, which are pull in from a merge. As discussed on slack, please do one of the following:
4
branch as a basePlease also check that you have read the checkbox information and applied it correctly - for example you've ticked "CI is green" but CI hasn't even run. This makes it hard to trust that you've even looked at any of the information in the checkboxes.
Oh I thought the "This branch has no conflicts with the base branch" was apart of the CI.
For future reference, how can I tell when the CI has run and if its green?
Right now you'll see something like this (not exactly the same but it should tell you something's awaiting approval)
When CI has passed, it'll literally be green and say "All checks have passed"
The favicon should also have a green tick when CI has passed and is green.
Oh Okay thank you
@mooror Just a reminder to please fix this PR as per https://github.com/colymba/GridFieldBulkEditingTools/pull/297#issuecomment-2254659948
@mooror FYI we're tagging the beta for the next minor release next week - if this doesn't get merged before then it'll be another 6 months before the next release.
Oh thanks for the reminders. I will try to get this done today
Replaced by #302
This PR adds the $fileID and $record variables to the "onBulkUpload" extension point that is in the createDataObject() method (in BulkUploadHandler.php). This allows developers to easily set additional fields on the newly created records and use data from the uploaded file to do so.
See the related issue for a usage example
Description
Manual testing steps
Issues
296
Pull request checklist