search

silverstripe / silverstripe-html5

Further HTML 5 support for Silverstripe.
BSD 3-Clause "New" or "Revised" License
14 stars 10 forks source link

WIP catch an edge case for parsing #20

Closed NightJar closed 6 years ago

NightJar commented 6 years ago

At current any field with a Shortcode in it (e.g. [code] ) is translated as expected into it's replacement content, however thanks to this html5 module it also comes accompanied by a random tag at the end.

dhensby commented 6 years ago

that is so fantastically bizarre

NightJar commented 6 years ago

Sure is, but it also appears to be 100% to do with the way we 'handle' shortcodes. In that we don't really handle them, we just throw regex at it and hope for the best, then inject invalid tags so we can find the reference again later. Have an upcoming PR for that too (proper parsing).

NightJar commented 6 years ago

Turns out no, 100% to do with some weird environmental thing with the backing library. wew what a doozy - I could not replicate it with the library alone.

Expanded investigation lead to see that this will also solve #19

robbieaverill commented 6 years ago

Nice work :-)

dhensby commented 6 years ago

@robbieaverill you're too keen, my man

robbieaverill commented 6 years ago

@dhensby sorry, will follow up your feedback tomorrow with @NightJar :-)