search

silverstripe / silverstripe-html5

Further HTML 5 support for Silverstripe.
BSD 3-Clause "New" or "Revised" License
14 stars 10 forks source link

Pulls/2.0/dependency debug #24

Closed NightJar closed 6 years ago

NightJar commented 6 years ago

Go back to the original parser as it does not cause conflicts with the rest of the framework. We can look at going back to an updated library when we drop support for PHP 5.6, or core stops having issues by way of integration between the shortcode parser and html5 value.

Resolves #22

robbieaverill commented 6 years ago

Minor phpcs violation needs to be fixed

NightJar commented 6 years ago

Yeah, I'm trying to fix the phpcs thing, interesting that running phpcs doesn't pick anything up on my local :/

robbieaverill commented 6 years ago

phpcs in Travis was 3.2.3, you might need to update your local version

NightJar commented 6 years ago

Also 3.2.3 - a fresh requirement I had to include directly just now to test that it wasn't a version issue. I thought it must be some config, but even when I directed to the framework standard it passed... 🤷‍♂️

NightJar commented 6 years ago

Ah yep, whoops, nice catch :)

robbieaverill commented 6 years ago

I think since we're changing dependencies that it should be a minor release, so we should release this change as 2.1.0 instead of 2.0.1. There are some other patch commits that could be released in 2.0.1 and/or merged up first too.