Specified cookie domain bugfix

silverstripe / silverstripe-hybridsessions

Hybrid Cookie / DB Session store for Silverstripe

BSD 3-Clause "New" or "Revised" License

16 stars 21 forks source link

Specified cookie domain bugfix #24

Closed DShumkov closed 7 years ago

DShumkov commented 7 years ago

I've found a bug when I use Session::set_cookie_domain('.example.com'). I think methods: open() and destroy() at HybridSessionStore_Cookie don't work normally cause domain name parmeter missed on Cookie::set and Cookie::force_expiry in case we use specific cookie domain.

DShumkov commented 7 years ago

Hmmmm I've run tests on my local env - it is all ok.

tractorcow commented 7 years ago

Do you know why travis is failing with a parse error?

tractorcow commented 7 years ago

PHP Parse error: syntax error, unexpected T_VARIABLE in /home/travis/builds/ss/hybridsessions/code/HybridSessionStore.php on line 245

tractorcow commented 7 years ago

dhensby commented 7 years ago

we still have test failures

wilr commented 7 years ago

Fixed in the #27