search

silverstripe / silverstripe-hybridsessions

Hybrid Cookie / DB Session store for Silverstripe
BSD 3-Clause "New" or "Revised" License
16 stars 21 forks source link

Updated write and destroy methods #32

Closed 806software closed 6 years ago

806software commented 6 years ago

Updated write and destroy methods so that an expected boolean is returned.

dhensby commented 6 years ago

should we ever be returning false for any of these methods?

806software commented 6 years ago

Probably, I guess if something went wrong? For the destroy method, the handlers don't appear to indicate if anything went wrong (well the DB one doesn't actually do anything).

For the write handlers, I guess we should actually return the value from the handler.

Now, it loops through the handlers. Therefore I guess we need to wait to see if we get a false from all. Otherwise if we get at least one true, that's ok?

Admittedly, I was going for the quick win on this one.