search

silverstripe / silverstripe-hybridsessions

Hybrid Cookie / DB Session store for Silverstripe
BSD 3-Clause "New" or "Revised" License
16 stars 21 forks source link

Remove mcrypt for 7.1 compatibility #36

Closed silverstripe-elliot closed 6 years ago

silverstripe-elliot commented 6 years ago

We have an installation of SS3.6 running on PHP7.1. Mcrypt is deprecated for this version, so we've replaced it with the OpenSSL equivalents created for SS4 compatibility.

robbieaverill commented 6 years ago

@tractorcow how do you feel about doing this in a minor release for the SS3 version of this module?

We're technically not changing the PHP API of this module by doing this, but we would be changing the requirements of the module.

robbieaverill commented 6 years ago

I'm creating a 1 branch now so we can change it from 1.1

Edit OK, done. Could you change the branch to 1 for this PR and rebase onto that branch please?

silverstripe-elliot commented 6 years ago

We're just making a small change to the README

silverstripe-elliot commented 6 years ago

Have added a hash_equals shiv to address <PHP 5.5 compatibility raised by TravisCI

silverstripe-elliot commented 6 years ago

@robbieaverill I've updated the base branch to 1

tractorcow commented 6 years ago

The code looks ok, theoretically... has this been tested on cwp with session storage?