search

silverstripe / silverstripe-hybridsessions

Hybrid Cookie / DB Session store for Silverstripe
BSD 3-Clause "New" or "Revised" License
16 stars 21 forks source link

Lack of PHP 7.2+ compatibility for 1.1 branch #56

Closed brynwhyman closed 5 years ago

brynwhyman commented 5 years ago

Identified by a server error on install: ERROR: Uncaught Error: Call to undefined function mcrypt_get_iv_size()

Looks like the required package "ext-openssl": "*", includes ext-mcrypt which is depreciated in PHP 7.1 and removed in PHP 7.2

robbieaverill commented 5 years ago

We may need to merge the branches up, it was fixed in 1.something already. Sec...

robbieaverill commented 5 years ago

Not a missing merge up. Are you sure that error isn't coming from a different part of your codebase, and that you're actually using 1.x of this module?

brynwhyman commented 5 years ago

Reporter was using version 1.1 of the module. Looks like the 1.2-rc1 branch has the patch to fix this?

emteknetnz commented 5 years ago

yup 1.2.0-rc1 version seems to work correct if you're using cwp 1.9.3-rc2 / php 7.3

robbieaverill commented 5 years ago

We released the new minor version to add PHP 7.2 support. It can't really be justified as a patch change since it switches from mcrypt to openssl as the default encryption provider. The fix is to use 1.2.x (which could be opted in for earlier CWP versions if you want to, I think)

NightJar commented 5 years ago

Thanks @robbieaverill - I note that 1.2.x is currently RC only, I'm thinking to just release it. Was there any particular reason you can recall as to why it was released as RC to begin with? (i.e. any reason a stable version might be a bad idea?)

robbieaverill commented 5 years ago

It was part of CWP 1.9’s release candidate

NightJar commented 5 years ago

Normally we tag modules as stable though, only recipes go through release candidate phases. Is your recommendation to wait for stable release to tag stable, or just do it now?

robbieaverill commented 5 years ago

Go for gold :-)

NightJar commented 5 years ago

Thanks for confirming. FTR: waiting for consensus from folks outside of this thread. Sounds like there's some reservation around (more 'real world') testing.

Tagged :) https://github.com/silverstripe/silverstripe-hybridsessions/releases/tag/1.2.0