search

silverstripe / silverstripe-linkfield

Silverstripe module for managing links
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

Fix or remove loading LinkModal via injector #202

Closed emteknetnz closed 8 months ago

emteknetnz commented 8 months ago

The use of loadComponent(LinkModal.${handlerName}); in LinkModalContainer.js caused this hard to diagnose issue https://github.com/silverstripe/silverstripe-linkfield/pull/85#issuecomment-1926014854

Either fix this so that it doesn't cause re-rendering issue in elemental, or remove it and use <LinkModal> directly

emteknetnz commented 8 months ago

Going with this approach instead - no need to make this a reusable hook as was discussed in slack as there are no other function components in sink that use loadComponent()