search

silverstripe / silverstripe-linkfield

Silverstripe module for managing links
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

NEW Allow developers to exclude LinkText field #215

Closed GuySartorelli closed 4 months ago

GuySartorelli commented 4 months ago

Because this gets passed from PHP through to JS, back to PHP for the controller, and then finally through to JS again for the form modal, I think the only way to adequately test this is through behat tests. There's a card in progress right now to create behat tests, so I'm not going to duplicate efforts creating a behat setup in this PR.

If the reviewer agrees, I'll create a separate card to add behat tests for this scenario, which can be blocked on the existing behat card.

Issue

GuySartorelli commented 4 months ago

Add a unit test on LinkFieldController that passing an 'excludeLinkTextField' get param will result in a schema without a LinkText field

Done