ENH Improve component focusing

silverstripe / silverstripe-linkfield

Silverstripe module for managing links

BSD 3-Clause "New" or "Revised" License

4 stars 13 forks source link

Closed emteknetnz closed 3 months ago

emteknetnz commented 3 months ago

This PR:

Makes focus when using mouse and keyboard consistent. Previously only using the keyboard has special logic for setting the focus state
Fixes a timing issue with focus when using a keyboard
Swaps around the tab order of the drag handle so that it is last rather than first

GuySartorelli commented 3 months ago

Other than the specific problems above, it works great locally.

emteknetnz commented 3 months ago

When I archive a link and then reorder links via the keyboard I get this error in the console:

I'm unable to replicate this. Could you please double check this is still happening with the latest version of this PR and if so then demo it to me.

GuySartorelli commented 3 months ago

Can't replicate that problem anymore, no idea what was causing it. LGTM but has merge conflicts.

emteknetnz commented 3 months ago

Done