search

silverstripe / silverstripe-linkfield

Silverstripe module for managing links
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

NEW LinkableMigrationTask for migrating sheadawson-lin kable links #261

Closed sabina-talipova closed 5 months ago

sabina-talipova commented 6 months ago

Description

These changes use the already developed logic of GorriecoeMigrationTask class. Since the Model structure of these two modules is almost identical, common GorriecoeMigrationTask logic was separated into a ModuleMigrationTaskTrait and implemented in LinkableMigrationTask for ease of support in the future. Also, minor changes were made to MigrationTaskTrait and the classIsOldLink class method was removed. Tests have been added and documentation on migration from the Linkable module to LinkField has been updated.

Parent issue

Note: For further implementation, it is required that this PR be merged into the main branch 4 first.

sabina-talipova commented 5 months ago

There were a lot of pushes since the last review - I'm assuming that there weren't any changes unrelated to the changes I requested. If you did make other changes, please let me know so I can review them.

No, there are not any new changes in the code, except one. I moved performMigration() from ModuleMigrationTaskTrait to the tasks, as you required. I had to test remotely, since time to time some tests failed with unrelated error in the local environment.