silverstripe / silverstripe-linkfield

Silverstripe module for managing links
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Migration tasks missing from 4.0.0-rc1 #272

Closed elliot-sawyer closed 2 months ago

elliot-sawyer commented 2 months ago

Module version(s) affected

4.0.0-rc1

Description

When trying to follow the migration guide for GorrieCoe LinkField, there are docs referencing a task that's missing.

composer require silverstripe/linkfield:^4

https://github.com/silverstripe/silverstripe-linkfield/tree/4.0.0-rc1/src/Tasks -> 404

How to reproduce

vendor/bin/sake dev/tasks/linkfield-tov4-migration-task

Possible Solution

recommit with src/Tasks folder (present in 4 branch and beta1 tag)

Additional Context

No response

Validations

elliot-sawyer commented 2 months ago

Just spotted @deprecated 4.0.0 Will be removed without equivalent functionality., which seems a bit odd to me. Why would you do all the work to offer a migration path, with excellent documentation, to this new module just to remove it in v4?

GuySartorelli commented 2 months ago

The migration tasks and docs are targetting the Silverstripe CMS 5.3 release (i.e. the silverstripe/linkfield 4.1.0 release) - they unfortunately didn't make it in time for the 5.2 (linkfield 4.0) release and depend on some ORM API changes that aren't going to be available in Silverstripe CMS 5.2.

They tasks are deprecated because they'll be removed in a future major release. They're not being removed in v4, they're being added in v4 and removed in a future major release.