search

silverstripe / silverstripe-mathspamprotection

BSD 3-Clause "New" or "Revised" License
19 stars 20 forks source link

Minor fix for French lang-file and proposed fix for entities showing on title attribute #8

Closed Juanitou closed 11 years ago

wilr commented 12 years ago

ATTTitle should use raw2att()

Juanitou commented 12 years ago

Hi Will!

That’s what I tried at first, but the combined string in French (issued from fr.yml): Question anti-spam : %sCombien font %s plus %s ?

…becomes even worse with raw2att(): Question anti-spam : Combien font cinq plus huit&nbsp?

That’s the reason I used the html2raw function but in fact I think we just have to decode entities with something as html_entity_decode. Do you want me to make this change and re-commit?

Hope it helps, Juan

Juanitou commented 12 years ago

We could as well remove entities from those lang files, what do you think?