search

silverstripe / silverstripe-mfa

MultiFactor Authentication for Silverstripe CMS
BSD 3-Clause "New" or "Revised" License
11 stars 24 forks source link

Transifex translations are not being added during a release #441

Open bitwingsde opened 2 years ago

bitwingsde commented 2 years ago

There is a German translation for this module in transifex, but the translations are not being pulled when the module gets new minor releases:

https://www.transifex.com/silverstripe/silverstripe-mfa/language/de/

tom890180 commented 1 year ago

Hey,

We've translated this module to swedish and finnish as well, and we'd appreciate if these translations were pulled in. I would make a pull request myself but on tx pull I don't get any new ones (not even the german ones), so I assume they need to be reviewed first (?)

Tom

NightJar commented 1 year ago

@GuySartorelli Thanks for updating the translations. The OP here from @bitwingsde mentions that this has been an issue over several releases in the past though. Is there an issue with the release process that needs to be fixed?

GuySartorelli commented 1 year ago

@emteknetnz was the person who updated the translations and has done releases before whereas I have only supported. To the best of my knowledge the release process will pull in translations, I can't speak for why this might not have happened in previous releases.

emteknetnz commented 1 year ago

I'm not 100% sure, though my best guess was there wasn't a minor release for the MFA module during the previous minor release (4.11), thus the translations were not run. At this stage translations are only regularly run and released during "official" minor releases where the sub modules (such as the MFA module) also have new minor releases created.

NightJar commented 1 year ago

Yeah, the translation update is run as part of the "main" release tool, cow. Minor releases tagged or created via GitHub won't have that step taken automatically and must be performed manually beforehand.

I thought cow checked for translations during the release process so would create a releasable commit "on the fly" during the process... but I'm probably remembering wrong & the tx update happens after the "should release" calculation.

Anyway... is there some kind of "before release" GitHub Action hook that could do a thing like that, so it isn't forgotten in the future? And/or pre-tag git hook?

Just brainstorming ideas at this point to try and avoid this in the future :)