search

silverstripe / silverstripe-mfa

MultiFactor Authentication for Silverstripe CMS
BSD 3-Clause "New" or "Revised" License
11 stars 24 forks source link

EnabledMembers report doesn't export calculated fields #443

Closed madmatt closed 2 years ago

madmatt commented 2 years ago

Report as seen in the CMS: image

Report export example: image

It looks like the 'Registered methods' and 'Default method' columns don't export at all.

PRs

emteknetnz commented 2 years ago

Issue is that formatting isn't getting applied in the context of the GridFieldExportButton https://github.com/silverstripe/silverstripe-framework/blob/4/src/Forms/GridField/GridFieldExportButton.php#L250

https://github.com/silverstripe/silverstripe-mfa/blob/4/src/Report/EnabledMembers.php#L99

The "Skipped registration" column is showing 0/1 instead of the formatted 'No'/'Yes' ... though this is functionally OK

emteknetnz commented 2 years ago

PR https://github.com/silverstripe/silverstripe-mfa/pull/444

emteknetnz commented 2 years ago

Linked PR has been merged, will probably be released around the same time as CMS 4.11 (likely Mar/Apr) - @madmatt let me know if you require this to be released sooner

maxime-rainville commented 2 years ago

Looks like this got fixed.