silverstripe / silverstripe-mfa

MultiFactor Authentication for Silverstripe CMS
BSD 3-Clause "New" or "Revised" License
11 stars 24 forks source link

FIX Export registered methods in enabled members report #444

Closed emteknetnz closed 2 years ago

emteknetnz commented 2 years ago

Issue https://github.com/silverstripe/silverstripe-mfa/issues/443

GridFieldExportButton doesn't apply formatting. I actually try fixing it that way first here before realizing this is probably bad because the exported data may included HTML link hyperlinks which will looks really bad in a csv

So I think the proper solution is don't manipulate data in a formatting function, instead just create some new 'get' methods that do the data manipulation

Also fixed some phpcs issues

michalkleiner commented 2 years ago

Test failure related.