silverstripe / silverstripe-mfa

MultiFactor Authentication for Silverstripe CMS
BSD 3-Clause "New" or "Revised" License
11 stars 24 forks source link

Add 'margin 0' to 'mfa-method-tile-group' #452

Closed TheBnl closed 2 years ago

TheBnl commented 2 years ago

Add margin: 0 to .mfa-method-tile-group so the selectable options are centered. At the moment the default margin left is still set on the tile group. Removing the margin centers the tiles. I presume a build is made when a new version is released?

Current state:

Schermafbeelding 2022-04-13 om 16 17 29

With the margin: 0;

Schermafbeelding 2022-04-13 om 16 16 51

dhensby commented 2 years ago

you need to build the dist files

TheBnl commented 2 years ago

Thats fine, but the project isn't buildable because of an failing scss import for non existing "variables" in the files bundle.scss and bundle-cms.scss:

// Core variables
@import 'variables';

The commands i've run to build:

node10 # command i use to switch to node version 10
yarn # install the required packages as defined in the yarn.lock file
yarn build

Then i get:

ERROR in ./client/src/bundles/bundle.scss
Module build failed: ModuleBuildError: Module build failed: 
@import 'variables';
^
      File to import not found or unreadable: variables.

Also i can't find any reference to "variables " in files other than bundle.scss and bundle-cms.scss.

Maybe there is a package missing?

TheBnl commented 2 years ago

Alright the import gets resolved when module is installed in a project, after reading trough the webpack-config i noticed styles are imported from the admin module.