fix: incorrect created date shown on backup method

silverstripe / silverstripe-mfa

MultiFactor Authentication for Silverstripe CMS

BSD 3-Clause "New" or "Revised" License

11 stars 25 forks source link

fix: incorrect created date shown on backup method #572

Open gavynj opened 2 weeks ago

gavynj commented 2 weeks ago

This PR fixes issue https://github.com/silverstripe/silverstripe-mfa/issues/571

When viewing a member, at the bottom of their member screen on the backend it says whether they have MFA setup and when their recovery codes were created. However, for any user that has MFA setup, the recovery codes created date always shows as today.

michalkleiner commented 2 weeks ago

Nice finds! The changes look ok to me. I wonder whether we should require the member to be passed always and not fallback to the current user at all.

You may also want to update the doc block when you add a method param and strongly type it to Member.

michalkleiner commented 2 weeks ago

The lint failure is related.