search

silverstripe / silverstripe-populate

Populate your database through YAML files
BSD 3-Clause "New" or "Revised" License
26 stars 24 forks source link

Feature: Allow Populate to build on live environments via config #37

Closed chrispenny closed 3 years ago

chrispenny commented 3 years ago

Closes #28

By default, builds are allowed on dev and test, but disallowed on live. This PR does not change that default behaviour.

Added a new configuration for allow_build_on_live which allows developers to specify that builds are also allowed on live.

While I won't be using this configuration myself, I couldn't really think of a valid reason for the module to make this determination of behalf of all developers. If a developer wishes to allow builds on live, then (imo) we should trust that they have understood the risks, and allow them to do it.

michalkleiner commented 3 years ago

The number of edits to the README makes it a bit difficult to review what are relevant changes and what are just tidy-ups, any chance of not updating what doesn't need updating and doing the clean up in a separate PR?

chrispenny commented 3 years ago

Thanks, @michalkleiner! I have reduced the noise in the README and actioned your change request.

madmatt commented 3 years ago

Yep, LGTM with your two minor suggested changed merged, thanks for your review @michalkleiner!

Merging on green.