search

silverstripe / silverstripe-populate

Populate your database through YAML files
BSD 3-Clause "New" or "Revised" License
26 stars 24 forks source link

Fix creating file instance using fixture file extension #41

Closed satrun77 closed 2 years ago

satrun77 commented 2 years ago

Fix for #40

GuySartorelli commented 2 years ago

This looks good overall. @satrun77 how would you feel about writing a unit test for this?

jakxnz commented 2 years ago

@satrun77 any chance you can get this up-to-date with tests? I've encountered the issue this solves in the wild, so would be great to have it in.

GuySartorelli commented 2 years ago

The broken builds for PHP < 7.4 can be ignored - I'll create a separate PR for updating the travis config for this module, but for the purposes of this PR the php 7.4 build passing is sufficient.

GuySartorelli commented 2 years ago

Pinging @silverstripe/core-team to see if someone has some time to merge this in, since I don't have access to do it.