search

silverstripe / silverstripe-raygun

Raygun.com integration for PHP
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Filter out database credentials and Raygun API key by default #29

Closed emteknetnz closed 6 years ago

emteknetnz commented 6 years ago

Filter out ss database credentials and raygun api key by default

On some hosting providers these variables can end up in $_SERVER, meaning they'll get send to raygun

Note: this PR is merging the '1' branch which is for SS3.x

sminnee commented 6 years ago

I think that we could be a bit broader than this and filter out anything that contained the words "password", "pass", "pwd", "username, "uname", "private", or "key"

sminnee commented 6 years ago

Note that the keys of setFilterParams can be regexes as long as they start with "/"

sminnee commented 6 years ago

The implementation of this PR is in master, so we can probably merge this to begin with and make the change I suggested on both the 1 and master branches as a separate improvement.

sminnee commented 6 years ago

@timkung can you review this and merge if you're happy? I've made you (and @micmania1) a committer.